-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All in one Fan Card #134
base: release
Are you sure you want to change the base?
All in one Fan Card #134
Conversation
Wow, thank you very much @sildehoop! Excuse my ignorance, but what are the specific advantages over the fan card from @saxel? |
The fan card from @saxel? is not working form me and I don't need the oscillate future and you cannot turn it off with thad card. |
But wil look if I can make all the fan card versions
|
Or do jou also want to combine collapsable and slider like fan card from @saxel? - type: custom:button-card
template: custom_card_saxel_fan_blue
entity: fan.smart_fan
name: Fan
variables:
collapsable: false
oscillate_attribute: oscillate |
But maybe the variables is getting a bit too much then |
In one card variables:
collapsable: false
show_oscillate: false
oscillate_attribute: "YOUR_OSCILLATE_ATTRIBUTE"
show_attributes: false
always_show_attributes: false
ulm_card_fan_slider_name: "YOUR_NAME"
ulm_card_fan_slider_temp_attribute: "YOUR_TEMP_ATTRIBUTE"
ulm_card_fan_slider_hum_attribute: "YOUR_HUM_ATTRIBUTE" |
Weird I don't have any problems with my custom fan card even with the latest update on the dev branch. Curious to know why it wouldn't work for you? Solution is not to create another card 😛I didn't think there were smart fans that also didn't have the possibility to toggle oscillating function hence I didn't make it configurable. But if you don't need the button for oscillating then it sounds like you could just inherit from the |
That is also not the main reason😛 and yes I took the |
Perhaps you can join forces here to revise the existing card accordingly? The end-user configuration could maxbe be a little slimmed down by making some variables optional and not have to specify? Do not get me wrong @sildehoop. I think your work is great and I appreciate it. But for my perception your cards, at least at first sight, look too similar. This may also confuse the end user when we eventually have x fan cards. 😀 Or what is your general opinion on this? |
Yes I am withe you to make it as simple as possible for the end user, I will make designs for al the options we have now and communicate with @saxel if he wants to join forces 😀 |
And a question for you what you think is the best keep them separated like the light card or join all options |
Happy to work together, I just don't know how best to deal with the card_light_slider if we don't have the oscillate button. Then it would in practice be two cards that could behave the same way. Should the card_light_slider base template be a bit more generic and allow for more configuration? The inclusion of horizontal button is a good addition 👍 Also, this is my personal preference but I don't think I would want to see the humidity as an extra attribute on the same card even though my fan offers this attribute. Personally I don't see the need to display this which will also keep the dashboard extra clean. So as long as that can be easily configurable then I'm good 😀 |
Nice, I had previously suggested to make the cards more configurable #105 and still don't now wat is the best solution. These are just Figma Mockups so no hard dissections on the color (like your blue better too)😄 https://www.figma.com/file/dOQKR8DCP2mvH7zesjU8L6/UI-Lovelace-Minimalist?node-id=0%3A1 In Figma you also see thad I have some base designs were I work from |
Ohh and I did use the colours of 7ahang's so don't now way they look so different Edit: oh I know you used the colors form his first design. Both: https://www.figma.com/file/dOQKR8DCP2mvH7zesjU8L6/UI-Lovelace-Minimalist?node-id=42%3A295 |
@sildehoop regarding the issue you had with the blue card: See #156 where there was a bug introduced with the pre-commit hook changes. I didn't notice it before because I hadn't updated my own custom card 😆 |
Oops, something went wrong here. I accidentally deleted the dev branch. But wait vll still with a new PR. Maybe we move the repo this week |
Will this support fans with only several set speeds; low, medium, high vs ones with a percentage? |
Maybe we can do both |
@sildehoop here's attributes of an example fan I have, controlled via RF through Broadlink. Could use "speed_list" attribute to populate available steps and names?: speed_list: off, low, medium, high |
Just out of curiosity: Is there any reason, why this does not become a 'core' card instead of a custom card? Btw: Card looks amazing! |
If this is ready it will be a core component😄 |
I don't have a lot of time so have not been working on it recently. |
Is there any update on this ? |
No sorry I started it but don't have time to finish it. |
I am super excited when this card is finished, i use the WIP actually. |
This is something I've put together for my own purposes, if anything may be useful.
|
Propose closing this PR without merging. Outdated and any further updates can be done on new Fan Card in PR #1194 |
I have made a Fan Card and Fan Slider Card with temperature and humidity label.
To do: