Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card Cover Custom Colors #1204

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Card Cover Custom Colors #1204

merged 5 commits into from
Mar 9, 2023

Conversation

benbur98
Copy link
Contributor

@benbur98 benbur98 commented Mar 8, 2023 •
edited

Cover Updates:

  • Ability to set any color instead of just fixing it to Blue
  • Slider Override Min/Max Values

CSS Grid Code Updated slightly on Both Cards to be more flexible for future additions of rows

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the contribution guidelines

Please feel free to test these changes out :)

@basbruss
Copy link
Collaborator

basbruss commented Mar 8, 2023 •
edited

@benbur98 Thank you very much for your contributions.

Please create different PR's for each different card. This makes everything better trackable. Also, you seem to have ignored the contribution guidelines with selecting the correct branch:

  • This PR is for a custom-card or documentation change and therefore directed to the main branch.
  • This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

Same holds for #1194

@benbur98 benbur98 changed the base branch from main to release March 8, 2023 22:43
@benbur98 benbur98 changed the base branch from release to main March 8, 2023 22:43
@basbruss basbruss changed the base branch from main to release March 8, 2023 22:50
@benbur98
Copy link
Contributor Author

benbur98 commented Mar 8, 2023

@basbruss Sorry, you're quite right... I'll re-read the guidelines now to get it right from now on!

@benbur98 benbur98 changed the title Card Cover Custom Colors and Light Card Brightness Preset Buttons Card Cover Custom Colors Mar 8, 2023
@basbruss
Copy link
Collaborator

basbruss commented Mar 9, 2023

@benbur98 I have pushed a commit to update some logic for the different modes, and also to remove some small bugs.

benbur98
benbur98 commented Mar 9, 2023
View reviewed changes
Copy link
Contributor Author

@benbur98 benbur98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small query. Otherwise I've tested and this works well for me. Thanks

...omponents/ui_lovelace_minimalist/lovelace/ulm_templates/card_templates/cards/card_cover.yaml Show resolved Hide resolved
@basbruss basbruss merged commit 9c786d0 into UI-Lovelace-Minimalist:release Mar 9, 2023
@benbur98 benbur98 deleted the card_cover_updates branch March 9, 2023 14:06
@basbruss basbruss linked an issue Mar 10, 2023 that may be closed by this pull request
Cover Card Percentage Always Visible #1188
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogun160 shogun160 shogun160 left review comments

@basbruss basbruss basbruss approved these changes

Assignees
No one assigned
Labels
✨ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cover Card Percentage Always Visible
3 participants
@benbur98 @basbruss @shogun160