Card Fan as a New Base Card

[benbur98]

Fix Issue #1191

I have created a new card based largely from @saxel fan card. This has been completely re-based to follow the modern format from the Light Card. I feel this card is now ready to be a base card and not a custom-card.

I believe this should Close and Replace PR #134.

[benbur98]

I've also added a fix for Issue #1188

[wokkeltje13]

3 remarks:

• I can't get the blue color
  
• oscillate button does not work
  
• after sliding to 0 and then enable the fan again, the slider remains on 0
  

My yaml code (formatting seems to be broken here on github even when pasted as code)

• type: "custom:button-card"
  template: card_fan
  entity: fan.ventilator_bureau
  variables:
  ulm_card_fan_name: Ventilator
  ulm_card_fan_enable_slider: true
  ulm_card_fan_enable_color: "blue"
  ulm_card_fan_force_background_color: true
  ulm_card_fan_enable_collapse: true
  ulm_card_fan_enable_button: true
  ulm_card_fan_button_icon: "mdi:rotate-3d-variant"
  ulm_card_fan_button_service: "fan.oscillate"

thanks already

[wokkeltje13]

Maybe a 4th remark, clicking on the button icon should toggle the fan on/off

[benbur98]

hi @wokkeltje13 - really appreciate you're feedback on this.
The Color not showing is because I have named the variable: "ulm_card_fan_color" and not "ulm_card_fan_enable_color" - good spot, I'll update the documentation.
I've fixed the oscillation by hardcoding this, the service needs some specific service data so currently I can't work out a good way to make this button customisable.
For me clicking on the button does toggle the fan - I'm not too sure what you mean there?
I also cannot re-create your issue with the slider....
I'll keep looking

[wokkeltje13]

Line 97 still contains the old var name in the exemple

[wokkeltje13]

The slider issue seems to be gone, can't reproduce anymore.

• Color is OK
• Oscillate is still not working
  
• Clicking still investigation if it has something to do with custom actions, but everywhere I click, the details open instead off toggle

[wokkeltje13]

Togle is working after adding fan to my custom actions

[wokkeltje13]

Fixed oscillating button by adding extra var

oscillate_attribute: "oscillate"

and by changing the code to

              oscillating: "[[[ return !entity.attributes[variables.oscillate_attribute] ]]]"

1 issue still open, the button does not toggle color according to oscillating state

[jimpastos]

These should probably be null or empty checks. The attributes are strings

[benbur98]

Have fixed this - however moving forwards I am personally focussing on the new card_fan and leaving the saxel fan behind.

[jimpastos]

also this and hum_str should be defined outside the if scope

[benbur98]

Have fixed this - however moving forwards I am personally focussing on the new card_fan and leaving the saxel fan behind.

[benbur98]

@wokkeltje13 > 1 issue still open, the button does not toggle color according to oscillating state

I have copied across the code from the old Saxel Fan for this button color, won't be able to test for a few days now but feel free to test yourself if you can :)

[wokkeltje13]

The oscillate button is working now, but the color is still not changing when toggle.
tnx already

[wokkeltje13]

I removed a part of the code and switched te colors and it seems to be working now.

The last part of card_fan.yaml I use now is:

      button:
        card:
          type: "custom:button-card"
          template:
            - "widget_icon"
          icon: "[[[ return variables.ulm_card_fan_button_icon ]]]"
          entity: "[[[ return entity.entity_id ]]]"
          tap_action:
            action: "call-service"
            service: "[[[ return variables.ulm_card_fan_button_service ]]]"
            service_data:
              entity_id: "[[[ return entity.entity_id ]]]"
              oscillating: "[[[ return !entity.attributes[variables.ulm_card_fan_oscillate_attribute] ]]]"
          state:
            - operator: "template"
              value: "[[[ return entity.state === 'on' && entity.attributes[variables.ulm_card_fan_oscillate_attribute]; ]]]"
              styles:
                card:
                  - background-color: "rgba(61, 90, 254, 1)"
                icon:
                  - color: "rgba(250, 250, 250, 1)"
                label:
                  - color: "rgba(250, 250, 250, 1)"
                name:
                  - color: "rgba(250, 250, 250, 1)"
                img_cell:
                  - background-color: "rgba(250, 250, 250, 0.2)"
            - operator: "template"
              value: "[[[ return entity.state === 'on' && !entity.attributes[variables.ulm_card_fan_oscillate_attribute]; ]]]"
              styles:
                card:
                  - background-color: "rgba(250, 250, 250, 1)"
                icon:
                  - color: "rgba(61, 90, 254, 1)"
                label:
                  - color: "rgba(250, 250, 250, 1)"
                name:
                  - color: "rgba(250, 250, 250, 1)"
                img_cell:
                  - background-color: "rgba(250, 250, 250, 0.2)"

[benbur98]

Thanks @wokkeltje13 - saved me some time! Looks like I left in some code from the light card that was taking over...

In general, I'm still not too pleased with how un-adaptable this button is (both in services and color), but I can continue to work on it over time... for now we have a good baseline card to go off at least.

[wokkeltje13]

tnx, seems to be working as expected

[wokkeltje13]

can approve the new fan card and the changes to the cover card. No comment on the saxel card that is EOL with the new fan card

The base branch was changed.

[basbruss]

@benbur98 I have updated the color logic to be more inline with the example pictures