-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-et option (default factor threshold) and Hassan's factor thr file are (effectively) ignored. #19
Labels
Comments
bryan-lunt
added a commit
that referenced
this issue
Mar 27, 2015
bryan-lunt
added a commit
that referenced
this issue
Mar 27, 2015
Some more formal tests, and then we can close this issue. |
bryan-lunt
added a commit
that referenced
this issue
Mar 30, 2015
Done. |
bryan-lunt
added a commit
that referenced
this issue
Apr 1, 2015
bryan-lunt
added a commit
that referenced
this issue
Apr 1, 2015
bryan-lunt
added a commit
that referenced
this issue
Apr 1, 2015
thoroughly, but might be ok. (merged)
This was referenced Apr 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Users should resolve by vote which order these get resolved in.
Currently, the factor thresholds will be input if they are provided in the .par file, but the other input locations are, in effect, ignored.
So we need to decide which order to resolve these in.
My preference is :
-ft (The factor threshold file) overwrites the input from
-et (The overall default factor threashold) which overwrites the input from
the .par file
The reason this is effectively ignored is that from neither of the first sources does it make its way into the parameters that get fed into the ExprPredictor (They do get used for the initial annotation.).
Unfortunately ExprPredictor re-annotates every sequence each time it's called on to make a prediction.
(That's fine if you want to learn the annotation threshold, but because it never got the values that were specified earlier, it means it starts at the default.)
The text was updated successfully, but these errors were encountered: