Allow reports without financial year to be accessed #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historical “ingested” reports don’t have any financial year and quarter. Many of the features built around a report rely on the report having a financial quarter and year, and break if the report doesn’t. In order to allow the historical reports to be accessed and downloaded, we need to add a lot of guards against the lack of financial year and quarter. (Any reports being created now enforce the presence of a FY/FQ by assigning default values at creation, and the fields are readonly at database level.)
CristinaRO
force-pushed
the
1695-allow-old-ingest-reports-to-be-accessed
branch
from
bd30bfd
to
079abb5
Compare
pezholio
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Historical “ingested” reports don’t have any financial year and quarter.
Many of the features built around a report rely on the report having a financial quarter and year, and break if the report doesn’t.
In order to allow the historical reports to be accessed and downloaded, we need to add a lot of guards against the lack of financial year and quarter.
(Any reports being created now enforce the presence of a FY/FQ by assigning default values at creation, and the fields are readonly at database level.)
Next steps
CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.