(2931/5) Feature flag for new import service #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuldt
changed the title
mec
changed the title
mec
force-pushed
the
feature/2931-feature-flag-for-new-import-service
branch
6 times, most recently
from
94739e5
to
579a718
Compare
|
Will be good to go on develop once the release is out of the way (and once it's rebased)! |
mec
force-pushed
the
feature/2931-feature-flag-for-new-import-service
branch
from
579a718
to
77a6288
Compare
When extending the Import::RowError for use in the new importer we changed the name of this attrbiute from `csv_row` to `csv_row_number` as it was felt to be more descriptive. However, whilst running both importers and switching between them, we want to retain compatibility - the old importer uses `csv_row` so we need to implement that for now, once we are confident in the new importer we can strip out the old including this.
The new Actuals, Refund and Activity comment importer is ready to be tested. To allow us to do so we want to have control over which importer the application uses. Right now, we want to change as little as possible, keeping the existing UI for testing. Once we have confidence the importer is working as expected, we can come back and make the most of the new behaviour. The feature flag is managed by Rollout and is called: `use_new_activity_actual_refund_comment_importer`
mec
force-pushed
the
feature/2931-feature-flag-for-new-import-service
branch
from
77a6288
to
4cd8a2e
Compare
CristinaRO
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work allows us to switch between the old Actual and Refund importer (
Actual::Import) and the new Acutal, Refund and Activity comment importer.The goal here is to test the importer with DSIT in development or staging so they are confident it does everything they want.
Once we are happy, we will come back and update the UI to make the most of the new importer.