Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(2931/5) Feature flag for new import service #2306

Merged
merged 2 commits into from
Jan 16, 2024
Merged

(2931/5) Feature flag for new import service #2306

merged 2 commits into from
Jan 16, 2024

Commits on Jan 16, 2024

  1. Retain compatibility with exiting import view 

    When extending the Import::RowError for use in the new importer we
changed the name of this attrbiute from `csv_row` to `csv_row_number` as
it was felt to be more descriptive.

However, whilst running both importers and switching between them, we
want to retain compatibility - the old importer uses `csv_row` so we
need to implement that for now, once we are confident in the new
importer we can strip out the old including this.
    @mec
    mec committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e464954 View commit details
    Browse the repository at this point in the history

  2. Support feature flag to use new importer 

    The new Actuals, Refund and Activity comment importer is ready to be
tested. To allow us to do so we want to have control over which importer
the application uses.

Right now, we want to change as little as possible, keeping the existing
UI for testing.

Once we have confidence the importer is working as expected, we can come
back and make the most of the new behaviour.

The feature flag is managed by Rollout and is called:

`use_new_activity_actual_refund_comment_importer`
    @mec
    mec committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4cd8a2e View commit details
    Browse the repository at this point in the history