Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly describe form validation errors #166

Merged
merged 13 commits into from
Jul 29, 2024
Merged

Properly describe form validation errors #166

merged 13 commits into from
Jul 29, 2024

Conversation

ecstaticrainbow
Copy link
Contributor

@ecstaticrainbow ecstaticrainbow commented Mar 1, 2024 •
edited by github-actions bot

Fixes #161

📦 Published PR as canary version: 0.14.1--canary.166.75fa4c4.0

✨ Test out this PR locally via:

npm install @ukho/admiralty-angular@0.14.1--canary.166.75fa4c4.0
npm install @ukho/admiralty-core@0.14.1--canary.166.75fa4c4.0
# or 
yarn add @ukho/admiralty-angular@0.14.1--canary.166.75fa4c4.0
yarn add @ukho/admiralty-core@0.14.1--canary.166.75fa4c4.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@lstevens98 lstevens98 added enhancement New feature or request accessibility labels May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@lstevens98 lstevens98 marked this pull request as ready for review July 10, 2024 08:48
@lstevens98 lstevens98 requested a review from a team as a code owner July 10, 2024 08:48
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-166.westeurope.azurestaticapps.net

@lstevens98 lstevens98 merged commit 6ec3366 into main Jul 29, 2024
13 checks passed
@lstevens98 lstevens98 deleted the describe-input-error branch July 29, 2024 08:20
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v0.14.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buzzub buzzub buzzub approved these changes

@lstevens98 lstevens98 lstevens98 approved these changes

Assignees

@lstevens98 lstevens98

Labels
accessibility enhancement New feature or request package: core released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] If an input error is automatically detected then the error is described to the user
3 participants
@ecstaticrainbow @buzzub @lstevens98