expanded alert component to handle auto hide #14
Conversation
joefitter
changed the title
|
WIPing this as need a way to pass props to the alert snippet |
joefitter
changed the title
joefitter
force-pushed
the
bugfix/notifications-component
branch
from
c563c9b
to
902b488
Compare
joefitter
force-pushed
the
bugfix/notifications-component
branch
from
902b488
to
7d06043
Compare
| timer() { | ||
| if (this.props.timeout && this.props.message) { | ||
| notificationTimeout = setTimeout(this.props.hideNotification, this.props.timeout); | ||
| } |
There was a problem hiding this comment.
We probably want to clear the timeout somewhere around here too.
In the case where a notification fires, and then 4 seconds later another one fires, the latter would only be displayed for 1 second.
There was a problem hiding this comment.
I'd also move it outside the condition, to cover even more extreme edge cases where the first notification was se to time out, but the second was not.
src/wrapper/index.jsx
Outdated
| @@ -1,9 +1,9 @@ | |||
| import React, { Fragment } from 'react'; | |||
| import { Alert } from '../'; | |||
| import { Notifiction } from '../'; | |||
There was a problem hiding this comment.
It's mildly alarming that this passed CI.
There was a problem hiding this comment.
I'm guessing it must either be undefined by default (which is CRAZY) or more likely: rollup sucks
There was a problem hiding this comment.
another reason we should get rid of the build - no errors are currently thrown on compile
No description provided.