Feature - billing

[joefitter]

• Added asru routes for updating billing and loading billing history

[joefitter]

WIP until
UKHomeOffice/asl-service#176
UKHomeOffice/asl-components#99
UKHomeOffice/asl-pages#653
UKHomeOffice/asl-public-api#207
UKHomeOffice/asl-internal-api#46
UKHomeOffice/asl-workflow#193
UKHomeOffice/asl-resolver#122

[joefitter]

Billing notes:

External

External admin users have a licence-fees page accessed from the dashboard where they can see fees for current year. PILs include revoked and transfers that happened in that year, figures reflect this but we should add a lot of test coverage around this.

Fees and dates are defined here: https://github.com/UKHomeOffice/asl-pages/pull/653/files#diff-d249ae431a0871ff9768ad3dac381134R1-R28 - this should be checked to make sure the figures are correct, also it will need a new entry adding for 2020 financial year.

Previous years can be accessed (if defined in config file above), if year is not found it will default to 2019.

Internal

As above, but non-transferred licences have a billing property which can be changed by asru users by expanding the column and adding a comment.

History of billable changes are shown if present - these are taken from workflow using model-tasks with new filters (action and status) - this method works fine for current financial year, but we perhaps need to look at how to filter billable licences for previous years. Currently billable is a default true boolean on the model, we may need to make a join table similar to pil transfers?

internal all licences

All licence fees accessed through footer link, includes similar overview to above but for all establishments, also includes transferred licences twice (if still billable) as I remember this being a requirement (to and from establishment both billed in transfer year)

All personal licences tab - only includes active licences, transferred licences are not doubled up, they probably should show twice for the from and to establishment but I couldn't work out the join magic required.

To do

• Investigate historical billing status
• Don't default to 2019 in internal ui routing - should be most recent entry or current financial year
• Include transferred licences in internal all licences list

To merge

• asl-permissions g2g
• asl-schema g2g
• asl-components g2g
• asl-workflow g2g
• asl-resolver needs asl-schema
• asl-internal-api needs asl-schema and asl-service
• asl-public-api needs asl-schema and asl-service
• asl-pages needs asl-components and asl-service
• asl-internal-ui needs asl-pages, asl-service and asl-components
• asl needs asl-pages, asl-service and asl-components

[lennym]

Now WIP until UKHomeOffice/asl-components#101 and UKHomeOffice/asl-pages#665

[wheelsandcogs]

is this redundant / deprecated?

[wheelsandcogs]

.then({ json: { meta, data }} => {
  res.locals.static.fees = {
    ...pick(meta, ['startDate', 'endDate']),
    ...pick(data, ['fees', 'personal', 'establishment', 'total']),
    numPils: data.numberOfPils,
    numPels: data.numberOfPels,
    year: req.year
  };
})

[lennym]

WHO ARE YOU AND WHAT HAVE YOU DONE WITH PHIL?!

[lennym]

[wheelsandcogs]

haha trying to fill in for @joefitter

[lennym]

Too far. Too. Far.