CrossEncoder device #2463
Merged
CrossEncoder device #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Aarsen <37621491+tomaarsen@users.noreply.github.com>
Co-authored-by: Tom Aarsen <37621491+tomaarsen@users.noreply.github.com>
Co-authored-by: Tom Aarsen <37621491+tomaarsen@users.noreply.github.com>
|
Hello! This looks good at a glance! I also like moving I'll try it out locally in a minute
|
|
Very clean indeed, no comments here! Thanks a bunch for this.
|
Not a problem!
|
debanjum
added a commit
to khoj-ai/khoj
that referenced
this pull request
Mar 10, 2024
- Trigger SentenceTransformer Cross Encoder models now run fast on GPU enabled machines, including Mac ARM devices since UKPLab/sentence-transformers#2463 - Details - Use cross-encoder to rerank search results by default on GPU machines and when using an inference server - Only call search API when pause in typing search query on web, desktop apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This pull request focuses on enhancing device compatibility and improving code organization by relocating the
get_device_namemethod and utilizing it to support the 'mps' device inCrossEncoder.py.Key Changes
get_device_namefromSentenceTransformer.pytoutil.pyfor better modularity.CrossEncoder.pyto useget_device_namefromutil.py, enabling support for the 'mps' device.Testing
CrossEncoderfunctions correctly with 'mps' device support.Conclusion
get_device_namefunction toutil.py.CrossEncoderto support 'mps' devices, improving performance on macOS platforms.