Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] Don't always normalize the embeddings in clustering example #2520

Merged

Conversation

tomaarsen
Copy link
Collaborator

Closes #2519

Hello!

Pull Request overview

  • Don't always normalize the embeddings in clustering example

Details

This change no longer automatically normalizes the embeddings, but does still show that it might be beneficial if the model doesn't already automatically do it.

  • Tom Aarsen

@tomaarsen tomaarsen merged commit aad0642 into UKPLab:master Mar 1, 2024
9 checks passed
@tomaarsen tomaarsen deleted the examples/clustering_dont_always_norm branch March 1, 2024 07:41
@archit15singh
Copy link

Thanks @tomaarsen for the clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants