Allow passing 'precision' when using 'encode_multi_process' to SentenceTransformer #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess' with SentenceTransformer
|
Hello! This looks solid, thanks for this! Could you please run
|
|
Done |
|
Excellent, thanks a bunch for this! I appreciate it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using the current implementation of 'encode_multi_process' we are forced to use only the default precision, forcing us to leverage multi-process GPU capabilities.
Details
This PR should fix this and allow setting the precision with multi-process capabilities by supporting the
precisionproperty when calling theencode_multi_processfunction.