N-06 [Oval] State Variable Visibility Not Explicitly Declared (#21)

Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
UMAprotocol · Jun 19, 2024 · 2552ef0 · 2552ef0
1 parent ff31b1b
commit 2552ef0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/factories/StandardCoinbaseFactory.sol b/src/factories/StandardCoinbaseFactory.sol
@@ -37,7 +37,7 @@ contract OvalCoinbase is MutableUnlockersController, CoinbaseSourceAdapter, Chai
  * mutability choices are desired.
  */
 contract StandardCoinbaseFactory is Ownable, BaseFactory {
-    IAggregatorV3SourceCoinbase immutable SOURCE;
+    IAggregatorV3SourceCoinbase public immutable SOURCE;
 
     constructor(IAggregatorV3SourceCoinbase _source, uint256 _maxTraversal, address[] memory _defaultUnlockers)
         BaseFactory(_maxTraversal, _defaultUnlockers)

diff --git a/src/factories/StandardPythFactory.sol b/src/factories/StandardPythFactory.sol
@@ -38,12 +38,12 @@ contract OvalPyth is MutableUnlockersController, PythSourceAdapter, ChainlinkDes
  * needed if different mutability or interface choices are desired.
  */
 contract StandardPythFactory is Ownable, BaseFactory {
-    IPyth immutable pyth;
+    IPyth public immutable PYTH;
 
     constructor(IPyth _pyth, uint256 _maxTraversal, address[] memory _defaultUnlockers)
         BaseFactory(_maxTraversal, _defaultUnlockers)
     {
-        pyth = _pyth;
+        PYTH = _pyth;
     }
 
     /**
@@ -56,7 +56,7 @@ contract StandardPythFactory is Ownable, BaseFactory {
      * @return oval deployed oval address.
      */
     function create(bytes32 pythPriceId, uint256 lockWindow, uint256 maxAge) external returns (address oval) {
-        oval = address(new OvalPyth(pyth, pythPriceId, defaultUnlockers, lockWindow, MAX_TRAVERSAL, maxAge, owner()));
+        oval = address(new OvalPyth(PYTH, pythPriceId, defaultUnlockers, lockWindow, MAX_TRAVERSAL, maxAge, owner()));
         emit OvalDeployed(msg.sender, oval, lockWindow, MAX_TRAVERSAL, owner(), defaultUnlockers);
     }
 }