Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-06 [Oval] State Variable Visibility Not Explicitly Declared #21

Conversation

md0x
Copy link
Collaborator

@md0x md0x commented Jun 17, 2024

Fixes the following issue reported in the Oval Incremental Audit:

Throughout the codebase, there are state variables that lack explicitly declared visibility:
The reporter state variable in CoinbaseOracle.sol
The SOURCE state variable in StandardCoinbaseFactory.sol
The pyth state variable in StandardPythFactory.sol

For clarity, consider always explicitly declaring the visibility of variables, even when the default
visibility matches the intended visibility.

Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Copy link

linear bot commented Jun 17, 2024

@md0x md0x marked this pull request as ready for review June 17, 2024 13:32
@@ -38,7 +38,7 @@ contract OvalPyth is MutableUnlockersController, PythSourceAdapter, ChainlinkDes
* needed if different mutability or interface choices are desired.
*/
contract StandardPythFactory is Ownable, BaseFactory {
IPyth immutable pyth;
IPyth public immutable pyth;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some inconsistency here: in the src/factories/StandardCoinbaseFactory.sol the public immutable variable is all caps. here, its not. This should be standardized. same goes for the src/oracles/CoinbaseOracle.sol

@md0x md0x changed the title fix[oval-audit-n-06]: State Variable Visibility Not Explicitly Declared N-06 [Oval] State Variable Visibility Not Explicitly Declared Jun 18, 2024
md0x added 2 commits June 18, 2024 17:49
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
@md0x md0x merged commit 2552ef0 into master Jun 19, 2024
3 checks passed
@md0x md0x deleted the pablo/uma-2653-n-06-oval-state-variable-visibility-not-explicitly-declared branch June 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants