Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate decimal scaling in uniswap anchored view source #11

Merged
merged 1 commit into from
May 16, 2024

Conversation

Reinis-FRP
Copy link
Collaborator

UniswapAnchoredViewSourceAdapter incorectly applied decimal scaling in its tryLatestDataAt method. Internal call to SnapshotSource._tryLatestDataAt already applies scaling when fetching latest data via getLatestSourceData, so no need to re-apply it.

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link
Collaborator

@md0x md0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Reinis-FRP Reinis-FRP merged commit 4e0428f into master May 16, 2024
3 checks passed
@Reinis-FRP Reinis-FRP deleted the reinis-frp/uniswap-anchored-scaling branch May 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants