[P2-N13] Remove TODOs #1327
[P2-N13] Remove TODOs #1327
Conversation
I believe these are all either done or we have decided not to do them (e.g., we're find the implementation of remargin). Signed-off-by: Prasad Tare <prasad.tare@gmail.com>
| @@ -258,7 +258,6 @@ contract PricelessPositionManager is FeePayer, AdministrateeInterface { | |||
| * @dev Might not withdraw the full requested amount in order to account for precision loss. | |||
| * @return amountWithdrawn The actual amount of collateral withdrawn. | |||
| */ | |||
| // TODO: Decide whether to fold this functionality into withdraw() method above. | |||
There was a problem hiding this comment.
@mrice32 We had discussed this, I think its still a decent idea to do this, but maybe not given time constraints.
There was a problem hiding this comment.
I thought we decided not to because it would be confusing to have the collateralAmount arg in this function call.
| @@ -200,7 +200,6 @@ contract Liquidatable is PricelessPositionManager { | |||
| PositionData storage positionToLiquidate = _getPositionData(sponsor); | |||
|
|
|||
| tokensLiquidated = FixedPoint.min(maxTokensToLiquidate, positionToLiquidate.tokensOutstanding); | |||
| // TODO: Limit liquidations from being too small or very close to 100% without being exactly 100%. | |||
|
I think the markdown linting is failing? I think this PR will have to wait for #1328. |
Ye, sorry about that. just caught it now. will be some teathing until our linter works on all markdown. It might actually be worth it to remove it from the CI pipeline so that we don't get blocked like this if |
Eh no worries. |
| @@ -258,7 +258,6 @@ contract PricelessPositionManager is FeePayer, AdministrateeInterface { | |||
| * @dev Might not withdraw the full requested amount in order to account for precision loss. | |||
| * @return amountWithdrawn The actual amount of collateral withdrawn. | |||
| */ | |||
| // TODO: Decide whether to fold this functionality into withdraw() method above. | |||
There was a problem hiding this comment.
I thought we decided not to because it would be confusing to have the collateralAmount arg in this function call.
I believe these are all either done or we have decided not to do them
(e.g., we're find the implementation of remargin).
Signed-off-by: Prasad Tare prasad.tare@gmail.com