Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P2-M03] Track sponsors via events #1353

Merged
merged 1 commit into from
May 5, 2020
Merged

[P2-M03] Track sponsors via events #1353

merged 1 commit into from
May 5, 2020

Conversation

nicholaspai
Copy link
Member

@nicholaspai nicholaspai commented May 4, 2020 •
edited
Loading

  • emit EndedSponsorPosition when sponsors are removed via transfers, settlements post-expiry, and liquidations.
  • No longer register any party members with EMPCreator
  • In EMPCreator's CreatedExpiringMultiParty event, renamed parameter from partyMemberAddress to deployerAddress

Signed-off-by: Nick Pai npai.nyc@gmail.com

@nicholaspai
emit EndedSponsorPosition when sponsors are removed. Don't register a…
50edf37 
…ny party members with EMPCreator

Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai nicholaspai added the audit-fix-phase2 Fixes for Phase 2 (EMP) of the OZ audit label May 4, 2020
@nicholaspai nicholaspai merged commit ed62317 into master May 5, 2020
@nicholaspai nicholaspai deleted the npai/unregistered-parties-2 branch May 5, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrice32 mrice32 mrice32 approved these changes

Assignees
No one assigned
Labels
audit-fix-phase2 Fixes for Phase 2 (EMP) of the OZ audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaspai @mrice32