[P2-M02] Make inequality consistent #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
nicholaspai
reviewed
May 7, 2020
| @@ -320,7 +320,7 @@ contract PricelessPositionManager is FeePayer, AdministrateeInterface { | |||
|
|
|||
| // Make sure the proposed expiration of this request is not post-expiry. | |||
| uint256 requestPassTime = getCurrentTime().add(withdrawalLiveness); | |||
| require(requestPassTime <= expirationTimestamp, "Request expires post-expiry"); | |||
| require(requestPassTime < expirationTimestamp, "Request expires post-expiry"); | |||
There was a problem hiding this comment.
You should make the same change in requestTransfer
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
nicholaspai
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know there are other ways that requests can be unwithdrawable, but I think it's still reasonable to make this inequality consistent.