improve(funding-rate-applier): Replace NewFundingRateMultiplier event with FundingRateUpdated #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
daywiss
reviewed
Dec 10, 2020
| int256 indexed latestFundingRate, | ||
| int256 periodRate | ||
| ); | ||
| event FundingRateUpdated(int256 newFundingRate, uint256 indexed updateTime); |
There was a problem hiding this comment.
I wonder if we should also have an event which emits the new cumulative multiplier. I cant really forsee how that would be useful though. I imagine if some offchain infra was using events to recreate historical contract state maybe this one event is enough to do that. thoughts?
There was a problem hiding this comment.
Yeah I think its sufficient to just read the cumulative multiplier on-chain. I don't think there's a need to see historical multipliers, but you should always know the current multiplier before modifying a position.
daywiss
approved these changes
Dec 10, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Pai npai.nyc@gmail.com
Motivation
#2282
Issue(s)
Fixes #2282