Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BridgeAdmin): validated amount sent is correct when making admin calls #3537

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

chrismaree
Copy link
Member

Motivation

OZ pointed out that:

_All functions in BridgeAdmin that call relayMessage assume the transaction value matches the l1CallValue parameter, but this is not enforced.

This PR addresses this by adding a require to the internal _relayMesage method to make this requirement.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

  • Ran end-to-end test, running the code as in production
  • New unit tests created
  • Existing tests adequate, no new tests required
  • All existing tests pass
  • Untested

Issue(s)

Fixes #XXXX

…alls

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
@nicholaspai nicholaspai changed the title fix(BridgeAdmin): validated amount sent is corect when making admin calls fix(BridgeAdmin): validated amount sent is correct when making admin calls Nov 1, 2021
@nicholaspai nicholaspai added the audit-fix-phase5 Fixes for Phase 5 of the OZ audit label Nov 1, 2021
@chrismaree chrismaree merged commit 3bfd30d into master Nov 2, 2021
@chrismaree chrismaree deleted the chrismaree/n05 branch November 2, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-fix-phase5 Fixes for Phase 5 of the OZ audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants