Update icons and metadata to meet Flathub requirements #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MolassesLover
commented
Apr 16, 2024
|
Thanks for the pull. I reviewed and it seems ok to me. I commit it. Thanks again. |
8 tasks
No problem, thanks for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of my previous pull request.
I removed an unused AppStream file, created for Blender packages. The metadata of that file focused on the Blender branding, and wouldn't be appropriate for packages of UPBGE. I replaced it with a new AppStream file that meets the FreeDesktop standards, and Flathub requirements.
AppStream files no longer use the
.appdata.xmlextension, either, instead using.metainfo.xml. For the sake of compatibility with older programs, I symbolically linkedorg.upbge.UPBGE.metainfo.xmltoorg.upbge.UPBGE.appdata.xml.Some icons were renamed to match the metadata requirements, as well. I made sure to update their paths in the CMake build script that installs them.
Please view the Flathub conversation here.