New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org.upbge.UPBGE #4713
Add org.upbge.UPBGE #4713
Conversation
I should note I got an okay to do submit this package from Jacob Merrill over on the UPBGE Discord server. Here is the message link. |
sorry but discord links are useless since it's not public. |
- install -Dm644 $FLATPAK_ID.appdata.xml /app/share/metainfo/$FLATPAK_ID.metainfo.xml | ||
sources: | ||
- type: archive | ||
url: https://github.com/UPBGE/upbge/releases/download/v0.36.1/upbge-0.36.1-linux-x86_64.tar.xz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no build from source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building Blender and its forks from source is extremely convoluted and not sustainable. Building each dependency from source is currently not very well supported by Blender, and as such you need to use the pre-compiled binaries which in return causes problems with building in a sandbox because of how their build system works. If there's a problem with this, please take it up to the official Blender Flatpak because I'm following their footsteps.
What should I do to prove I reached out to them then? Also, regarding the building of the Flatpak and its permissions, I feel like the problems should be discussed about the official Blender Flatpak, since this is directly based on that. UPBGE is almost identical to Blender, other than the fact it has added tools for game development. |
You can just copy the quote here.
I wouldn't take the questions too negatively. They are extensive permissions so they will always be pointed out. I think "This is literally Blender" is a fair enough reason, though it would be good for you to understand them if you maintain this package. |
Yeah, sorry if I came across as abrasive, it seemed really critical so I got confused. I'll make sure to reach out and ask about the Blender Flatpak. |
bot, build org.upbge.UPBGE |
Queued test build for org.upbge.UPBGE. |
Started test build 83048 |
Build 83048 successful
|
@MolassesLover Who should we invite from the upstream team to the Flathub repo? |
Building from this commit will result in a failure, as the `<url>` tag seems to be unsupported. ``` AppData problem: tag-invalid : <url> type invalid [unknown] ```
Both of the organisation owners. I already gave @BluePrintRandom a heads-up. |
The package now should build with the upstream
I assumed this meant the |
it's not a supported value. |
btw that appstream file is insufficient. missing |
and the id in the appstream file is incorrect too.
|
So should I make a pull request to update the file? That would mean it would only be available in the next release tag of UPBGE as well, and in that case should I just wait until then to update this Flatpak? |
it's an error if it doesn't match. it was correct previously. |
I'm not sure I understand? |
These files are now in conflict with the upstream, I will submit a merge request to add these files into the upstream UPBGE repository.
Okay, I made sure to lint this time, and I don't expect there to be any missing metadata. Sorry I didn't before, I hope it didn't cost much time. Please review my changes before I submit these updated files to the upstream UPBGE repository. |
Desktop file and metainfo file should be submitted upstream #4713 (comment) |
To clarify, you're satisfied with these files? |
Yes seems fine |
They merged my pull request of the files. All the appropriate metadata should be available in the upstream. |
Please try to switch to upstream provided metadata, could be done on the next release as well. bot, build org.upbge.UPBGE |
Queued test build for org.upbge.UPBGE. |
1 similar comment
Queued test build for org.upbge.UPBGE. |
Started test build 115719 |
Build 115719 successful
|
Let me know if everything is working ok. |
I tried the bot build on my system, everything is working fine. |
I'll make sure to switch on next release, I'm only packaging the tags. |
bot, build org.upbge.UPBGE |
Queued test build for org.upbge.UPBGE. |
Started test build 117136 |
Build 117136 successful
|
/merge |
A repository for this submission has been created: https://github.com/flathub/org.upbge.UPBGE You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you have never maintained an application before, common questions are answered in the app maintenance guide. Thanks! |
Please confirm your submission meets all the criteria
This is a package for the Uchronia Project Blender Game Engine (UPBGE,) a fork of Blender to maintain, and extend Blender's old game engine which was removed back in version 2.8. As the application is really similar to Blender, this package follows Blender's Flatpak closely. The permissions are exactly the same, and as the project is licensed under GPL 3.0; the license information is also identical.
This is my first Flatpak, so sorry if there's anything I missed!