Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.upbge.UPBGE #4713

Closed
wants to merge 9 commits into from

Conversation

MolassesLover
Copy link

@MolassesLover MolassesLover commented Nov 19, 2023

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub.
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

This is a package for the Uchronia Project Blender Game Engine (UPBGE,) a fork of Blender to maintain, and extend Blender's old game engine which was removed back in version 2.8. As the application is really similar to Blender, this package follows Blender's Flatpak closely. The permissions are exactly the same, and as the project is licensed under GPL 3.0; the license information is also identical.

This is my first Flatpak, so sorry if there's anything I missed!

@MolassesLover
Copy link
Author

I should note I got an okay to do submit this package from Jacob Merrill over on the UPBGE Discord server. Here is the message link.

@hfiguiere hfiguiere changed the title Wrote a Flatpak for org.upbge.UPBGE Add org.upbge.UPBGE Nov 19, 2023
@hfiguiere
Copy link
Contributor

sorry but discord links are useless since it's not public.

- install -Dm644 $FLATPAK_ID.appdata.xml /app/share/metainfo/$FLATPAK_ID.metainfo.xml
sources:
- type: archive
url: https://github.com/UPBGE/upbge/releases/download/v0.36.1/upbge-0.36.1-linux-x86_64.tar.xz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no build from source?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building Blender and its forks from source is extremely convoluted and not sustainable. Building each dependency from source is currently not very well supported by Blender, and as such you need to use the pre-compiled binaries which in return causes problems with building in a sandbox because of how their build system works. If there's a problem with this, please take it up to the official Blender Flatpak because I'm following their footsteps.

org.upbge.UPBGE.yml Outdated Show resolved Hide resolved
org.upbge.UPBGE.yml Show resolved Hide resolved
org.upbge.UPBGE.yml Show resolved Hide resolved
org.upbge.UPBGE.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@MolassesLover
Copy link
Author

sorry but discord links are useless since it's not public.

What should I do to prove I reached out to them then?

Also, regarding the building of the Flatpak and its permissions, I feel like the problems should be discussed about the official Blender Flatpak, since this is directly based on that.

UPBGE is almost identical to Blender, other than the fact it has added tools for game development.

@TingPing
Copy link
Member

What should I do to prove I reached out to them then?

You can just copy the quote here.

Also, regarding the building of the Flatpak and its permissions, I feel like the problems should be discussed about the official Blender Flatpak, since this is directly based on that.

I wouldn't take the questions too negatively. They are extensive permissions so they will always be pointed out. I think "This is literally Blender" is a fair enough reason, though it would be good for you to understand them if you maintain this package.

@MolassesLover
Copy link
Author

I wouldn't take the questions too negatively. They are extensive permissions so they will always be pointed out. I think "This is literally Blender" is a fair enough reason, though it would be good for you to understand them if you maintain this package.

Yeah, sorry if I came across as abrasive, it seemed really critical so I got confused. I'll make sure to reach out and ask about the Blender Flatpak.

@MolassesLover
Copy link
Author

You can just copy the quote here.

image

@barthalion
Copy link
Member

bot, build org.upbge.UPBGE

@flathubbot
Copy link

Queued test build for org.upbge.UPBGE.

@flathubbot
Copy link

Started test build 83048

@flathubbot
Copy link

Build 83048 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65684/org.upbge.UPBGE.flatpakref

@barthalion
Copy link
Member

@MolassesLover Who should we invite from the upstream team to the Flathub repo?

Building from this commit will result in a failure, as the `<url>` tag
seems to be unsupported.

```
AppData problem: tag-invalid : <url> type invalid [unknown]
```
@MolassesLover
Copy link
Author

MolassesLover commented Nov 24, 2023

@MolassesLover Who should we invite from the upstream team to the Flathub repo?

Both of the organisation owners. I already gave @BluePrintRandom a heads-up.

@MolassesLover
Copy link
Author

The package now should build with the upstream appdata.xml file. The thing is, it seems to fail now?

AppData problem: tag-invalid : <url> type invalid [unknown]

I assumed this meant the <url> tag isn't supported, but I checked, and I used it in my own file earlier. Is this a syntax error or something?

@hfiguiere
Copy link
Contributor

The package now should build with the upstream appdata.xml file. The thing is, it seems to fail now?

AppData problem: tag-invalid : <url> type invalid [unknown]

I assumed this meant the <url> tag isn't supported, but I checked, and I used it in my own file earlier. Is this a syntax error or something?

type

<url type="Github">https://github.com/UPBGE/upbge</url>

it's not a supported value.

@hfiguiere
Copy link
Contributor

btw that appstream file is insufficient. missing content_rating, releases and launcheable has an incorrect value since it doesn't match the installed .desktop file name.

@hfiguiere
Copy link
Contributor

and the id in the appstream file is incorrect too.

<id>org.upbgeteam.UPBGE</id> doesn't match.

@MolassesLover
Copy link
Author

So should I make a pull request to update the file? That would mean it would only be available in the next release tag of UPBGE as well, and in that case should I just wait until then to update this Flatpak?

@hfiguiere
Copy link
Contributor

it's an error if it doesn't match. it was correct previously.

@MolassesLover
Copy link
Author

it's an error if it doesn't match. it was correct previously.

I'm not sure I understand?

org.upbge.UPBGE.yml Outdated Show resolved Hide resolved
org.upbge.UPBGE.yml Outdated Show resolved Hide resolved
org.upbge.UPBGE.yml Outdated Show resolved Hide resolved
These files are now in conflict with the upstream, I will submit a merge
request to add these files into the upstream UPBGE repository.
@MolassesLover
Copy link
Author

Okay, I made sure to lint this time, and I don't expect there to be any missing metadata. Sorry I didn't before, I hope it didn't cost much time. Please review my changes before I submit these updated files to the upstream UPBGE repository.

org.upbge.UPBGE.yml Outdated Show resolved Hide resolved
@bbhtt
Copy link
Contributor

bbhtt commented Apr 16, 2024

Desktop file and metainfo file should be submitted upstream #4713 (comment)

@MolassesLover
Copy link
Author

Desktop file and metainfo file should be submitted upstream #4713 (comment)

To clarify, you're satisfied with these files?

@bbhtt
Copy link
Contributor

bbhtt commented Apr 16, 2024

Yes seems fine

@MolassesLover
Copy link
Author

MolassesLover commented Apr 18, 2024

Desktop file and metainfo file should be submitted upstream #4713 (comment)

They merged my pull request of the files. All the appropriate metadata should be available in the upstream.

@bbhtt
Copy link
Contributor

bbhtt commented Apr 19, 2024

They merged my pull request of the files. All the appropriate metadata should be available in the upstream.

Please try to switch to upstream provided metadata, could be done on the next release as well.

bot, build org.upbge.UPBGE

@flathubbot
Copy link

Queued test build for org.upbge.UPBGE.

1 similar comment
@flathubbot
Copy link

Queued test build for org.upbge.UPBGE.

@flathubbot
Copy link

Started test build 115719

@flathubbot
Copy link

Build 115719 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/98533/org.upbge.UPBGE.flatpakref

@bbhtt
Copy link
Contributor

bbhtt commented Apr 19, 2024

Let me know if everything is working ok.

@MolassesLover
Copy link
Author

flatpak install --user https://dl.flathub.org/build-repo/98533/org.upbge.UPBGE.flatpakref

Let me know if everything is working ok.

I tried the bot build on my system, everything is working fine.

@MolassesLover
Copy link
Author

Please try to switch to upstream provided metadata, could be done on the next release as well.

I'll make sure to switch on next release, I'm only packaging the tags.

@barthalion
Copy link
Member

bot, build org.upbge.UPBGE

@flathubbot
Copy link

Queued test build for org.upbge.UPBGE.

@flathubbot
Copy link

Started test build 117136

@flathubbot
Copy link

Build 117136 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99958/org.upbge.UPBGE.flatpakref

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/org.upbge.UPBGE

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants