-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataset metadata for new E&A to all relevant datasets #317
Conversation
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a5ccb52
to
5fac41b
Compare
I finished adding the layer thumbnails @j08lue . I didn't update the NOAA + methane ones as they don't load on E&A. Could revisit if needed 👍 |
Yes, we do not need layer thumbnails for those for now. We can add them later, if need arises. We will need the structured data, though, please, @siddharth0248, so we can use it in new designs of the Dataset cards in the Data Catalog (https://github.com/US-GHG-Center/ghgc-architecture/issues/133). |
@faustoperez @j08lue I have updated the mdx for all the required files and updated the checkbox list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two changes we need to make to the info
blocks:
- Units should be abbreviated
- Information that is not available should be omitted
info: | ||
source: NASA,NOAA | ||
spatialExtent: Global | ||
latency: N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When not available, information should be omitted from this list, rather than set to "N/A".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems fine to me - I'd like to take a look once everything is in the E&A environment, we may want to adjust a few things based on how it displays. (e.g. we may want to be more concise with how we describe latency for individual data layers)
info: | ||
source: NASA | ||
spatialExtent: Global | ||
latency: Monthly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the current latency isn't monthly, but we expect it to be once we receive the next CASA version update
- Spatial Resolution: 1° x 1° | ||
- Data Units: Teragrams of methane per year (Tg CH₄/yr) | ||
- Data Type: Research | ||
- Data Latency: Updated yearly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ECCO-Darwin we say "Updated annually" - we should choose one way of wording this for consistency
I merged the latest changes here into the preview at #319 - please check it out here: https://deploy-preview-319--ghg-demo.netlify.app/exploration |
@j08lue When you click on an info button for a dataset layer, I think it would be more useful to see the temporal resolution on the top line as opposed to the latency. (e.g. in this example "monthly" rather than "approximately 2 years" - what do you think? Was there a justification for choosing latency to go in this position? |
You are right. Sorry that I did not catch that earlier myself. This goes for the dataset card as well as the info page. Let us please replace this in all the files here - |
Done in the above commit. d54faf2 |
I made the changes we discussed, @Jeanne-le-Roux and @siddharth0248:
Can you give it one more look in this preview, please, @Jeanne-le-Roux, and confirm that it is ready to go out (when we launch E&A)? |
@j08lue I think this looks good. One more thing - right now the unique layer descriptions are only displayed when you are presented with layers to select, but when you click on the info button for a layer in the explore environment that short layer description doesn't seem to be there. This is something that we need to make sure is visible somewhere. |
Thanks, @Jeanne-le-Roux, I'll merge this PR then, to avoid more merge conflicts. Since the changes are backwards-compatible, there should be no issue in merging them already now, before the release of E&A. I ticketed your suggestion for adding the layer description to the info modal - should be a quick fix. |
Closes #303
infoDescription
blocks for each datasetinfo
blocks for each layermedia
blocks for each layerStructured info (info description)
Structured info (info blocks for each layer)
- [ ] noaa-cpfp-ch4-point- [ ] noaa-cpfp-co2-point- [ ] emit-ch4plume-v1Thumbnails
- [ ] noaa-cpfp-ch4-point- [ ] noaa-cpfp-co2-point- [ ] emit-ch4plume-v1