Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R2] Add new MiCASA and LPJ datasets and update dataset overview pages to new format #333

Merged
merged 49 commits into from Apr 26, 2024

Conversation

siddharth0248
Copy link

@siddharth0248 siddharth0248 commented Apr 1, 2024

Add new datasets for R2

  • Add MDX for MiCASA
  • Add MDX for LPJ
  • Update NOAA mdx
  • Update data insight - Intro to GHGC
  • Test visually in map exploration
  • Restructured the dataset landing page

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for ghg-demo ready!

Name Link
🔨 Latest commit 4e66164
🔍 Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/662bd1cf4a93c80008deae01
😎 Deploy Preview https://deploy-preview-333--ghg-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@siddharth0248

This comment was marked as resolved.

@slesaad

This comment was marked as resolved.

@j08lue

This comment was marked as resolved.

@j08lue j08lue changed the title New Dataset for R2 added [R2] Add new MiCASA and LPJ datasets Apr 8, 2024
@vincentsarago

This comment was marked as resolved.

@j08lue

This comment was marked as resolved.

@siddharth0248
Copy link
Author

Changed the min max values for each of the layer. This helps in distinguishing high and super high values. eg, USA and China

Original/Proposed values in document
image

Changed values
image

@deborahUAH please have a look

@vincentsarago
Copy link

After talking with @siddharth0248 and @SwordSaintLancelot we found that the dataset had a weird transform (origin of the file being lower right, instead of top right). For some Reason QGIS is able to work with it, but rio-tiler couldn't.

I've added a fix in rio-tiler cogeotiff/rio-tiler#696 which I hope to get merged/released today

@deborahUAH
Copy link

@siddharth0248 regarding images above about changing visualization scale. NBE is a new layer right? Confirm choice of color ramp and min/max for visualization with data provider.

@j08lue
Copy link
Collaborator

j08lue commented Apr 25, 2024

@siddharth0248 please check the ECCO Overview page - there was a merge conflict and I am not sure I kept the right edit. Looks like this now:

image

@j08lue
Copy link
Collaborator

j08lue commented Apr 25, 2024

MiCasa also still needs the additional layer info for E&A:

image

@siddharth0248
Copy link
Author

@jonas I haven't added the media section, because how don't know how you grabbed it. But rest of the Info needed for the data card and layers have been updated. I have also added monthly layer for LPJ_EOSIM

@j08lue
Copy link
Collaborator

j08lue commented Apr 25, 2024

I haven't added the media section, because how don't know how you grabbed it

Yeah, @faustoperez made the thumbnails last time

I think you can just take a screen grab from the rendered map of whichever extent and zoom level best brings out the characteristics of the dataset. You could also use the /raster/cog/preview endpoint of the tiler, if you anyways want a global coverage thumbnail, e.g.: https://dev.ghg.center/ghgcenter/api/raster/cog/preview?url=s3://ghgc-data-store-dev/MiCASA/v1/daily/2001/01/MiCASAv1_flux_NBE_x3600_y1800_daily_20010101.tif&colormap_name=purd&rescale=0%2C1.5

Copy link
Collaborator

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and complete now, apart from the missing layer thumbnails for MiCASA and LPj.

They have the fall-back to the dataset thumbnail, though, so that is not a blocker for merging.

image

@siddharth0248 siddharth0248 merged commit af7503d into develop Apr 26, 2024
5 checks passed
@siddharth0248 siddharth0248 deleted the new-dataset-sid branch April 26, 2024 16:16
@slesaad slesaad mentioned this pull request May 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants