Water Supply Accounting DTO #800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zack-rma
force-pushed
the
feature/water_supply_accounting_dto
branch
4 times, most recently
from
703dc80
to
e9f2cf9
Compare
zack-rma
force-pushed
the
feature/water_supply_accounting_dto
branch
2 times, most recently
from
13a2e8a
to
5ac239a
Compare
zack-rma
force-pushed
the
feature/water_supply_accounting_dto
branch
2 times, most recently
from
bc4642b
to
e8e85ba
Compare
…table tags to water user
…on ID input parameter
zack-rma
force-pushed
the
feature/water_supply_accounting_dto
branch
from
e7f8914
to
950e791
Compare
rma-psmorris
suggested changes
Aug 23, 2024
| private final String contractName; | ||
| @JsonProperty(required = true) | ||
| private final WaterUser waterUser; | ||
| private final List<PumpAccounting> pumpAccounting; |
There was a problem hiding this comment.
This data structure should be better defined. It should account for the different pumps and then the accounting times for a given pump. It should be able to easily answer without doing a full list scan whether a given pump has accounting, and what the given pump's start and end times are for the accounting.
There was a problem hiding this comment.
Restructured for less repeated data and better scaling
| }, | ||
| "water-right": "Test Water Right" | ||
| }, | ||
| "pump-accounting": [ |
There was a problem hiding this comment.
You have a lot of repeated data here w/in the pump accounting JSON. Accounting is a time series, and this portion of the data structure will need to scale.
There was a problem hiding this comment.
Rewrote for better scaling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Water Supply Accounting DTO with tests