Add devpath option to generate-policy. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allen-Webb
force-pushed
the
master
branch
3 times, most recently
from
e094e77
to
1a2e2cf
Compare
dkopecek
requested changes
Oct 8, 2018
Allen-Webb
force-pushed
the
master
branch
3 times, most recently
from
8b6dd24
to
f59780d
Compare
dkopecek
changed the title
Allen-Webb
force-pushed
the
master
branch
2 times, most recently
from
4c89ecb
to
01d4da9
Compare
dkopecek
approved these changes
Oct 25, 2018
|
LGTM. Thanks for investing time into this feature and the subsequent code deduplication! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows usbguard generate-policy to generate a policy line for a single device given the devpath without forcing a reenumeration of all the devices.