Use std::variant::emplace when loading #699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch constructs and loads the variant's contained value directly in place, instead of loading it outside and then moving it into place. This saves a move construction/assignment and thus benefits the case where moves aren't cheap (e.g. large POD). This also allows the signature and recursion logic of
variant_detail::load_variant
to be slightly simplified, since only the index is needed, not the type (the variant itself can figure out the type from the index).This is basically the same thing as #698 but applied to
variant
.