Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nation Preagg Surrogate Activity Weighting Issue #9

Closed
danielbizercox opened this issue Jan 20, 2021 · 1 comment
Closed

Nation Preagg Surrogate Activity Weighting Issue #9

danielbizercox opened this issue Jan 20, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@danielbizercox
Copy link
Collaborator

Nation Preagg uses various weighting methods to average activity by county, state, or fuel region to national averages. The tables that use the interim table SurrogateActivity do not have proper weighting because that table is (purposefully) missing values for Puerto Rico and the Virgin Islands during a Nation Preagg run, but it is used as if it sums to 1. This has a very small impact on results.

danielbizercox added a commit that referenced this issue Jan 21, 2021
Normalizing surrogate activity for the tables that are using the unweighted values
@danielbizercox danielbizercox added this to the v3.0.1 milestone Jan 21, 2021
@danielbizercox
Copy link
Collaborator Author

danielbizercox commented Jan 21, 2021

This has been fixed by correctly weighting the values in the SurrogateActivity table. Users who want to use this feature before we release version 3.0.1 can download the PreAggNation.sql file to the \database folder of their MOVES installation directory (overwriting the existing file). The model does not need to be recompiled to use this fix.

@danielbizercox danielbizercox added the bug Something isn't working label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant