Fixed bug in network graphic related to link colormap #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbonney
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
The updates make sense. Ran some of the tests and double checked the results against what main produces and they matched (when not using link_range), and when adding a custom link_range the new code produced the desired behavior. While reviewing I noticed we don't have any tests that provide custom inputs for link_range, though. Something to remember next time we take a pass at the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following update fixes a bug in the link colormap that is created in
plot_network. The previous code ignored user input fromlink_rangeand used only positive values.The PR also includes minor updates to demos.
Tests and documentation
NA
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.