Fix #433 - Gis files written with column title 'name' #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbonney
reviewed
Aug 2, 2024
There was a problem hiding this comment.
All changes make sense and contribute to more consistent index naming within WNTR functionality. These changes do change default behavior of WNTR, so it could potentially break code that relies on the default index name being "index" - we'll want to call this out in our next release.
Currently the doctests for the gis module are failing since they expect dataframes without an index name, but we are now naming it "name". @angusmcb, can you address this test failure?
|
Added additional tests to verify desired index name behavior across GIS functionality. Also addressed some doc testing issues that arose as a result of the index name changes. |
|
Thanks @kbonney, sorry I couldn't get to this in time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes default name column from 'index' to 'name' and removes a couple of instances where it was assumed that there was a column 'index'.
Fixes #433
Tests and documentation
n/a - not a new feature
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.