Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC review: Lock test file with commit instead of master #72

Closed
wants to merge 1 commit into from

Conversation

rcaneill
Copy link
Contributor

I believe that providing the exact version of the test file may avoid problems in the future if the upstream Coastal_Ecological_Indicators is updated

@jbousquin
Copy link
Collaborator

jbousquin commented Jul 2, 2024

I don't disagree, but my preference is to keep it standard for all the example files in this package and point to the main/master rather than the commit. (1) I'm the owner/maintainer of the other repo and don't anticipate changes to this file, and (2) I've seen others and been burned myself by github urls changing - if that happens generally I'm more aware, my concern would be that something would change for commits and being non-standard it would be harder to detect.

@rcaneill
Copy link
Contributor Author

rcaneill commented Jul 9, 2024

Ok sounds fair, I close this PR

@rcaneill rcaneill closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants