Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge slice #64

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Edge slice #64

merged 10 commits into from
Mar 8, 2024

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented Mar 8, 2024

Description

Separate the edge slice from our existing slices. With this, our store structure takes shape in a very manageable way.

we have the followign structure to our Decision Tree store. The Tree store has three sub-slices

  1. Node slice. Manages the creation/removal of visible nodes on the tree
  2. Edge Slice. Same as above but for edges that connect our nodes
  3. Decision Slice. Act as a sort of database that we pull information from to create Nodes and Edges.

There is also a tree slice which is a shared slice (it depends on the above three slices) and unifies the logic, present a clean, abstracted, interface for working with the store.

for example, the tree slice has a showNode action which dispatches actions in the subslices to (1) create a node, (2) create an edge, (3) update our decision slice to reflect the user decisions.

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions github-actions bot added the CI/CD continuous integration/continuous deployment label Mar 8, 2024
@dpgraham4401 dpgraham4401 merged commit c7bfab4 into USEPA:main Mar 8, 2024
8 checks passed
@dpgraham4401 dpgraham4401 deleted the edge_slice branch March 8, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD continuous integration/continuous deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant