Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag or check mark for authors that are corresponding authors #528

Closed
3 tasks
amruelama opened this issue May 24, 2017 · 4 comments
Closed
3 tasks

Comments

@amruelama
Copy link
Member

In GCIS, corresponding authors are 'the point of contact' authors. Currently, we relate them seperately, i.e., relate a person as author for an article and relate a person as point of contact for the same article. Going forward, we should be able to flag these authors to indicate two roles (author as primary role and point of contact as secondary role)

Things to do:

  • Add the check mark/ flag feature
  • Query all the authors with author and also POC roles.
  • Add the feature to those authors
@amruelama
Copy link
Member Author

@lomky Could you prioritize this, please? Looks like there are so many author POCs that we've been adding recently. Just adding the feature should be fine for now.

@lomky
Copy link
Collaborator

lomky commented Jun 5, 2017

@amruelama an easy way to make this happen is let the PoC continue to be a separate contributor relationship, but allow you to create it via a checkbox when assigning another role.

Pros:

  • no need to update existing data
  • no need to change data model
  • going forward, only one need to enter a person once

Cons:

  • none that stick out to me. Two lines to remove if you need to delete them?

Question: How often do you need to add a single person with more than one role other than PoC? Another way we could implement this is allow you to choose as many roles as you like during creation, and it makes all the relationships. That is a more general solution, but a bit more work.

@amruelama
Copy link
Member Author

@lomky I wouldn't worry about deleting two lines if I need to delete them. Since we are adding hundreds of contributors per week and we have around 90% of articles with authors that are POCs, anything that simplifies the process of adding multiple roles for contributors would be great. For now, we only have examples for author-POC multiple roles.

@lomky
Copy link
Collaborator

lomky commented Jun 9, 2017

We're going to move forward with making the role field a multiselect option, and letting the controller beneath handle creating the multiple relationships.

lomky added a commit that referenced this issue Jun 9, 2017
@lomky lomky mentioned this issue Jun 12, 2017
lomky added a commit that referenced this issue Jun 12, 2017
Release 1.50.1

Fixes #526
Fixes #531
Obsoletes #491
Fixes #325
Fixes #525
Fixes #527
Fixes #528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants