Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make generic attrs editable #582

Closed
lomky opened this issue Jan 8, 2018 · 3 comments
Closed

Make generic attrs editable #582

lomky opened this issue Jan 8, 2018 · 3 comments
Assignees
@lomky
Labels
an enhancement context Content Management priority high type technical

Comments

@lomky
Copy link
Collaborator

lomky commented Jan 8, 2018

Enables #572

This should work the way reference attrs are edited.
@lomky lomky self-assigned this Jan 8, 2018
@lomky
Copy link
Collaborator Author

lomky commented Jan 8, 2018

@amruelama how does this look?

screen shot 2018-01-08 at 11 12 50 am

@amruelama
Copy link
Member

Looks perfect! @lomky

@lomky
Copy link
Collaborator Author

lomky commented Jan 8, 2018

Cool! Now I'll make it actually work! :)

lomky added a commit that referenced this issue Jan 8, 2018
@lomky
Generic attributes are editable
0c53567 
Similar form to reference attribute editing.

Bumps #582
Enables #572
@lomky lomky mentioned this issue Jan 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomky lomky

Labels
an enhancement context Content Management priority high type technical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lomky @amruelama