Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type prov:Agent to instrument instances #226

Merged
merged 1 commit into from
Aug 19, 2015
Merged

Conversation

zednis
Copy link
Contributor

@zednis zednis commented Aug 19, 2015

references USGCRP/gcis-ontology/issues/124.

This type is inferable from the domain of prov:contributed; adding it to the template to make the type information explicit without requiring reasoning.

references USGCRP/gcis-ontology/issues/124.

This type is inferable from the domain of prov:contributed; adding it to the template to make the type information explicit without requiring reasoning.
@justgo129
Copy link
Contributor

👍

bduggan added a commit that referenced this pull request Aug 19, 2015
add type prov:Agent to instrument instances
@bduggan bduggan merged commit 12ee967 into USGCRP:master Aug 19, 2015
@bduggan
Copy link
Contributor

bduggan commented Aug 19, 2015

Merged, but I'm curious about handling this in general, e.g. everything used to explicitly be a prov:Entity but now that is only inferrable.

@bduggan
Copy link
Contributor

bduggan commented Aug 19, 2015

@zednis
Copy link
Contributor Author

zednis commented Aug 19, 2015

@bduggan was there a decision made to stop explicitly typing instances with type prov:Entity? Since we aren't running any reasoning on the instance data queries for instances of type prov:Entity do not return results.

This causes the default query at http://data.globalchange.gov/sparql to return 0 results.

I would say leave the explicit typing of inferrable types in until and unless we start doing RDFS inference prior to the triplestore load.

@bduggan
Copy link
Contributor

bduggan commented Aug 20, 2015

On Wednesday, August 19, Stephan Zednik wrote:

@bduggan was there a decision made to stop explicitly typing instances
with type prov:Entity?

Yes, I think so. The idea was that the templates should be as minimal
as possible. Having 'prov;Entity' in the templates is redundant and thus
incurs a maintainance cost (i.e. what is and what isn't a prov:Entity
has to be maintained in both the templates and the ontology).

Since we aren't running any reasoning
on the instance data queries for instances of type prov:Entity
do not return results.

This causes the default query at http://data.globalchange.gov/sparql to return 0 results.

I would say leave the explicit typing of inferrable types in until and unless we start doing RDFS inference prior to the triplestore load.

I would vote for doing inferencing (though I say this without
knowing what's involved on the technical side, e.g. why
does it have to be prior to the load, can't virtuoso do it
for us after the load?).

Brian

@zednis
Copy link
Contributor Author

zednis commented Aug 20, 2015

I'll create a new ticket in gcis for discussions on inferencing.

@justgo129
Copy link
Contributor

👍 for the new ticket. I'm a big fan of inferencing, by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants