Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update template to say model wasAttributedTo project #235

Merged
merged 3 commits into from
Sep 2, 2015

Conversation

zednis
Copy link
Contributor

@zednis zednis commented Aug 27, 2015

@zednis
Copy link
Contributor Author

zednis commented Aug 27, 2015

I also changed the use of gcis:ModelRun as a predicate to prov:wasUsedBy which is the PROV-O recommended inverse property to prov:used. This is the correct PROV relationship if gcis:ModelRun is used as an activity and not as the output entity. I did not see any instances of gcis:ModelRun or gcis:ModelRunOutput in the API or triplestore so I was not able to confirm that our use in the instance data aligns the semantics agreed upon in USGCRP/gcis-ontology/issues/17

@zednis
Copy link
Contributor Author

zednis commented Aug 27, 2015

Before we close this pull request - I am not sure if <<%= uri($model_run) %>> represents the model run output or the model run activity.

If it represents the output of the run (an entity) we will need to make an additional change to the pull request, replacing prov:wasUsedBy with prov:hadDerivation (saying the model run output was derived from the model).

@zednis
Copy link
Contributor Author

zednis commented Aug 31, 2015

Based on the discussion in USGCRP/gcis-ontology/issues/17 I am going to change the template pull request to use prov:hadDerivation instead of prov:wasUsedBy since it is now clear that <<%= uri($model_run) %>> is intended to represent the output dataset from a model run.

@justgo129
Copy link
Contributor

Assuming this is fine with @rewolfe, I'm fine to merge and subsequently close USGCRP/gcis-ontology#17.

@rewolfe
Copy link
Member

rewolfe commented Sep 1, 2015

+1

On Tue, Sep 1, 2015 at 1:43 PM, justgo129 notifications@github.com wrote:

Assuming this is fine with @rewolfe https://github.com/rewolfe, I'm
fine to merge and subsequently close USGCRP/gcis-ontology#17
USGCRP/gcis-ontology#17.


Reply to this email directly or view it on GitHub
#235 (comment).

Robert Wolfe, NASA GSFC @ USGCRP, o: 202-419-3470, m: 301-257-6966

@justgo129
Copy link
Contributor

@bduggan please feel free to merge at your convenience. We'll then close USGCRP/gcis-ontology#17.

@zednis
Copy link
Contributor Author

zednis commented Sep 1, 2015

before we merge - we could update the proposed change to use gcis:relatedProject instead of prov:wasAttributedTo. gcis:relatedProject is a subproperty of prov:wasAttributedTo so the desired provenance relationship will still hold and would be available to queries if inference is supported.

@justgo129
Copy link
Contributor

@zednis is that a recommendation or simply another option?

@zednis
Copy link
Contributor Author

zednis commented Sep 1, 2015

@justgo129 non-strong recommendation. Once we get inference working and are able to infer the prov:wasAttributedTo relationship from the subproperty it will be a stronger recommendation.

@justgo129
Copy link
Contributor

Sounds good. Let's go with the non-strong recommendation then. @zednis please feel free to update the necessary files accordingly. Once that is done, please inform @bduggan so that he can merge.

bduggan added a commit that referenced this pull request Sep 2, 2015
update template to say model wasAttributedTo project
@bduggan bduggan merged commit 8e54a8f into USGCRP:master Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants