Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retina Favicon. #274

Merged
merged 5 commits into from
Oct 12, 2017
Merged

Retina Favicon. #274

merged 5 commits into from
Oct 12, 2017

Conversation

mwernimont
Copy link
Contributor

Was able to create a favicon that will switch based on what size is needed. Found you can make a single favicon file with several sizes from https://www.smooster.com/en/blog/how-to-create-a-favicon-for-retina.html using http://www.xiconeditor.com/

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 73.653% when pulling 8ce9532 on mwernimont:master into c49240a on USGS-VIZLAB:master.

@jordansread
Copy link

cool: "Favicon is a word coined from the words “favorite” and “icon”." never knew.

Looks good. it wasn't clear from the help if we actually need more than one ico in the viz. Do we? or does one work and the non-retina views deal with the higher-res one appropriately?

I see one new image in the file, so is nothing needed (logic) to switch between multiple icos if they are needed?

@mwernimont
Copy link
Contributor Author

The one file contains 4 different ico files at different sizes. The browser will talk to the ico and and the ico will feed the appropriate size to the browser. At least that is what I'm reading. So this should cover any situation we have I believe @jread-usgs

@jordansread
Copy link

oh, ok. Limitation of GH's "view" just showed me one.

@jordansread jordansread merged commit 2c016e8 into USGS-VIZLAB:master Oct 12, 2017
@mwernimont
Copy link
Contributor Author

mwernimont commented Oct 12, 2017

Well it is one file. Idk how it all works, but it one file with multiple layers, and it decides which layer shows up. Kinda new to me, so if it does work it should be sweet. Way better than 4 different files floating around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants