Tooltip #282
Merged
Tooltip #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
aappling-usgs
approved these changes
Oct 15, 2017
|
|
||
| // remove all children from any tooltip group: | ||
| d3.selectAll("#tooltip-group").selectAll("*").remove(); | ||
| // does the above work to clear out multiple tooltips from multiple svgs? |
There was a problem hiding this comment.
i think it does - i commented out line 7 in developer tools, created a bunch of tooltips on the 2 svgs, and then called this line before and after calling d3.selectAll("#tooltip-group").selectAll("*"). all of the tooltips in both groups disappeared after the remove() call. are you confident now, too, and if so how about removing this line?
There was a problem hiding this comment.
yes, confident - how about I remove it in #284 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273
Now will PR on
exampleviz to add this functionality