Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamps #316

Merged
merged 25 commits into from
Oct 31, 2017
Merged

Timestamps #316

merged 25 commits into from
Oct 31, 2017

Conversation

aappling-usgs
Copy link
Member

@aappling-usgs aappling-usgs commented Oct 28, 2017

Timestamp checking is working.

Here's my best visual explanation of how vizlab treats file currency and timestamps so far (needs work, but it's a start):
image

The timestamp functionality is demonstrated in https://github.com/USGS-VIZLAB/vizlab/pull/316/files#diff-3066b18354ab4c8e1b10c0daa72dbcfe

I also updated the vignettes.

@aappling-usgs
Copy link
Member Author

tests work when run at console but fail w ctrl-shift-t. pushing here to see how travis does with it

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.0%) to 65.119% when pulling 86ac0cb on aappling-usgs:timestamps into 475953d on USGS-VIZLAB:remake.

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.0%) to 65.119% when pulling cd3484e on aappling-usgs:timestamps into 475953d on USGS-VIZLAB:remake.

@aappling-usgs
Copy link
Member Author

aappling-usgs commented Oct 28, 2017

It works! Sorry for the giant PR, but it's what was needed to get timestamps handled and properly tested...OK, and to get the testviz a bit more compliant with the style guide too. For reviewing, it's probably easiest to start with the tests to see how the package is supposed to behave. @ldecicco-USGS , do you have time to review this?

@aappling-usgs
Copy link
Member Author

also, createRemakefiles is atrociously long and i know it. i'm working on a refactor for an upcoming PR

@aappling-usgs
Copy link
Member Author

Here's the cleaned-up version of createRemakefiles: https://github.com/aappling-usgs/vizlab/compare/timestamps...aappling-usgs:parameters?expand=1#diff-3100aa6afab755cba48769133597a7a8. I'm not sure how to create a clean PR for it before this one is merged because it depends on this one, but I'll create it as soon as we're through with this one.

@ldecicco-USGS
Copy link
Contributor

Pulled it down, seemed to work as I expect. Super cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants