Fixes what is on dev & brings Harvey/Irma back #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited how publish-date is used so that blank fields never get built, dev builds anything with a date past or future, and prod only builds dates that are today's date or in the past.
Fix for Harvey and Irma: We aren't sure why this was implemented, but commented it out for now. It does not break any tests when we do. ef628ba
That is was was preventing Harvey and Irma from building because they get that warning due to https://github.com/USGS-VIZLAB/hurricane-harvey/blob/master/viz.yaml#L434 and https://github.com/USGS-VIZLAB/hurricane-irma/blob/master/viz.yaml#L696