Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding princeton roles and first shot at site preview on circle #2

Merged
merged 8 commits into from
Apr 8, 2021

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Jan 15, 2021

This will add two Princeton roles, along with the site preview on Circle. This will not be ready for review until I can get circle working (and hopefully it will trigger, otherwise I'll need to add the recipe in a separate PR!)

Signed-off-by: vsoch vsochat@stanford.edu

Signed-off-by: vsoch <vsochat@stanford.edu>
Signed-off-by: vsoch <vsochat@stanford.edu>
Signed-off-by: vsoch <vsochat@stanford.edu>
… if this is needed)

Signed-off-by: vsoch <vsochat@stanford.edu>
@vsoch
Copy link
Member Author

vsoch commented Jan 15, 2021

Okay we're good! As with most circle urls, the links won't actually work since we need to use index.html instead of the equivalent path without it. There are a few links on the site that use relative_path that aren't rendering correctly, but since it wouldn't link to the correct resource anyway, I think it's okay as is. Here are the links to view for this PR:

@cosden would you care to review?

@vsoch vsoch mentioned this pull request Feb 19, 2021
@cosden
Copy link
Member

cosden commented Apr 8, 2021

@vsoch sorry for being so incredibly slow with this. It seems the artifacts are gone, so I've attempted to rerun the circle preview and take a look!

@vsoch
Copy link
Member Author

vsoch commented Apr 8, 2021

Ok! Let me know what you think!

Copy link
Member

@cosden cosden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsoch: First off, this is a great idea and I like the sit design and structure very much. I have a few suggestions/comments that might not be appropriately scoped for this PR. I'll try my best in the context of the two Princeton roles. I'd remove the parenthetical parts of the title "(ORFE)" and "(social sciences)" as they aren't really part of the titles. However, it would be really good to have this information captured somewhere.

I think about who is going to use this and think that it would be desirable to have the following captured for each JD (ideally in a searchable fashion):

  • Formal Job title
  • Organization
  • Organization type
  • Department
  • Category
  • Full time/part time
  • Domain

So for example:

  • Research Software Engineer, Senior RSE, Scientific Programmer, Computer Scientist
  • Princeton University, ORNL,
  • University, National Lab, Industry
  • Research Computing, Molecular Biology, Computer Science,
  • IT, Research
  • Full time
  • Molecular Biology, Economics, HPC, etc

If this gets to be a big enough database having the ability to sift through different roles based on keywords in these categories would be great.

I think this could all be added later. So I'm fine with these Princeton roles and we can always come back later and add these categories/classifications.

vsoch and others added 2 commits April 8, 2021 11:27
Co-authored-by: Ian Cosden <cosden@users.noreply.github.com>
…sciences.md

Co-authored-by: Ian Cosden <cosden@users.noreply.github.com>
@vsoch
Copy link
Member Author

vsoch commented Apr 8, 2021

@cosden that's great feedback! I do think that's a direction we would want to go in. For now I'm just trying to get descriptions, period, so would you want to copy paste your careful thinking into an issue so we have it for the future, when we re-organize things?

@cosden
Copy link
Member

cosden commented Apr 8, 2021

OK. Moved longer comments to issue #4. Also made some small changes to the description because I have more than 2 that I can put in here. They are all similar wording so I don't know how much they add (they have different primary partnerships but much of the text is the same). @vsoch if/when it would be useful to add them here, let me know.

vsoch and others added 2 commits April 8, 2021 13:04
…sciences.md

Co-authored-by: Ian Cosden <cosden@users.noreply.github.com>
Co-authored-by: Ian Cosden <cosden@users.noreply.github.com>
@vsoch
Copy link
Member Author

vsoch commented Apr 8, 2021

@cosden if there are others that are somewhat different and would be useful to have, if you want to send them to me I can do another PR. If the differences are subtle but comparable here, we could have a section that describes this (in the same post). If they are so similar it wouldn’t be hugely interesting to have the redundancy, then we can skip. It’s up to you, I’m good with either.

@cosden
Copy link
Member

cosden commented Apr 8, 2021

The others for my group are 90% the same text. However the difference is in the scientific domain/applications, so interesting they are fundamentally quite different. My opinion would be to leave them off for now so as not to make anything about this valuable resource Princeton dominant. There are other groups at Princeton too that can/should be captured. Once we have 100 unique roles (we can hope!), having 10 very similar ones from my group matters far less.

Copy link
Member

@cosden cosden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good to go from my perspective!

@vsoch
Copy link
Member Author

vsoch commented Apr 8, 2021

let's merge!!

@vsoch vsoch merged commit d551bc3 into main Apr 8, 2021
@vsoch vsoch deleted the add/princeton-roles branch April 8, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site needs CI preview on Circle
2 participants