-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add internal news carousel for news and announcements page #744
Merged
Merged
Changes from 5 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
dfd2ad8
Change current news path to news-announcments
jcbcapps e3cecb4
Update test
jcbcapps bd02b3d
Add NewsCarousel and NewsCarouselItem components
jcbcapps 03cdf50
Update storybook component
jcbcapps 728db43
Add CTA
jcbcapps 66672cc
Add query for carousel articles
jcbcapps ba3009e
Add NewsCarousel component to page
jcbcapps c657ce9
Add custom ellipses and custom arrows
jcbcapps a902eff
Update styles
jcbcapps 077e442
Move class to module
jcbcapps e403e9c
fix: resolve type error from useRef return
gidjin b6520be
test: add article mock to NewsAnnouncements component
gidjin 444466a
fix a11y violation in carousel, update mock in test
abbyoung aa417ab
Style updates
jcbcapps afd2d18
Add test
jcbcapps 684bc33
Add test
jcbcapps c958f99
Add news page from main
jcbcapps 823e7b4
Add view older internal news link
jcbcapps 9b1914c
Add comment
jcbcapps 67fd32b
Update styles
jcbcapps e037e7a
Add conditional render for link
jcbcapps 4de79e5
Merge branch 'main' into sc-589/internal-news-carousel
jcbcapps 39cde4b
Merge branch 'main' into sc-589/internal-news-carousel
jcbcapps fd8bf16
Remove unnecessary importants
jcbcapps dd943d4
Update default image
jcbcapps 034b37f
Update tests
jcbcapps 82989b8
Merge branch 'main' into sc-589/internal-news-carousel
jcbcapps 4d98c22
Merge branch 'main' into sc-589/internal-news-carousel
jcbcapps ff84f0e
Remove flex styles
jcbcapps 679c517
Add comment
jcbcapps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
194 changes: 194 additions & 0 deletions
194
public/assets/images/Seal_of_the_United_States_Space_Force.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 15 additions & 6 deletions
21
src/components/NewsCarouselItem/NewsCarouselItem.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: I'm sad this todo doesn't reflect the valiant effort to make it happen. So the praise is for that valiant effort and being willing to set it aside for now.