-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alt section workflow #394
Conversation
…lay, removed max-width from contact-card
…favor of concrete
Now everything should be in order. I can't really think of anything else I would like to add for Forskå's sake in the near future. There will probably be some fixes and tweaks todo, but I think it is probably best to try to push this out before this branch grows even more out of control. |
This is a nice feature that I think we definitely should have. There is an issue however with webpages that currently exist. If we you apply this PR and have pages that has been created the old way, they get broken and the previous content does not get shown. You also can't access the previous content when editing them. We need to find some way to solve this, perhaps we can make a script that converts all the sites to the new format? |
Reworked in #399 |
Description of the Change
This is a major rework of how the front end blocks are structured. This PR primarily introduces a hierarchical block based workflow, but also reconfigures how some of the current block templates behave in order to fit into the hierarchy and to properly make use of materialize.css. Since this was such a big change I also took the liberty to implement some basic missing blocktypes based on materialize components.
This draft PR is to track progress for the finishing touches and to gather feedback and input.
In short blocks are now grouped into the following hierarchy:
Level 0: Sections
Level 1: Layout
Level 2: Standard
Level 3: Basics
Changelog
Added table block
Added divider block
Added icon block
Added collapsible container block
Added container block
Added button block
Added button-group block
Added paragraph block with selectable text-justification
Merged Map block
Added section block with "padding (small | medium | large)" and "extend full width" properties
Reworked Home and Web -pages to include body field blocks with section html tags
Reworked ResponsiveImage block to be properly responsive
Reworked Two column grid -> Flex Columns.
Reworked image overlay to include configurable height property, button group.
Reworked contact card template to now scale to parent width.
Removed image-description block (because it is just weird and redundant)
Removed image-icons block (same as above)
Image-description block and image-icons is removed because it just doesn't work well with the new layout system and it can practically be implemented with the new blocks. counters block should probably also be removed for the same reason but stands as is for now because the "darken" functionality is kinda unique and standardizing themeing is a pandoras box not to be opened now #329 .
Future improvements:
One day I would like to create custom forms for some of the blocks to make editing in the admin interface slightly smoother. Specifically Table block, Map block and maybe even Section (remove indentation). Im thinking adding a "horizontal list" form may be a good first step, also making all blocks collapsible would be nice.