Utrs 99 #4
Closed
Utrs 99 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e returning to this point, so committing anyway.
|
actualy, that's UTRS 101 |
| $firstuserid = "null"; | ||
| $seconduserid = null; | ||
| } else { | ||
| $firstuserid = User::getUserByUsername($username)->getUserId(); | ||
| $seconduserid = User::getUserByUsername($username)->getUserId(); |
There was a problem hiding this comment.
This will result in a second SQL query. $seconduserid = $firstuserid; should suffice, no?
There was a problem hiding this comment.
yes, it should. I considered that, but I went for what was closest to the original. your suggestion was my first thought too, and IMO a lot cleaner
| public function sendEmail($bodytemplate, $subject, $admin = false){ | ||
| $success = false; | ||
| try { | ||
| if (!$admin){ |
There was a problem hiding this comment.
Should be if ($admin === false)
|
closed again until I have it merged against the current master, because of the PDO transition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script to close UTRS 99.
Prerequisites:
Actions to actually close UTRS 99:
Quite some changes:
Add script (clean_requests.php) to send reminders when an appeal is AWAITING USER for 5 days or more, and to send close notification and close appeal 5 days after the reminder is sent.
Under the hood:
Because the changes are largish, good beta testing is prefered on this patch