Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbnl footnotes #1478

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

dbnl footnotes #1478

wants to merge 6 commits into from

Conversation

lukavdplas
Copy link
Contributor

Separates footnotes from the the main content in the DBNL corpus (close #1346)

This still needs to be re-indexed on production.

@lukavdplas lukavdplas marked this pull request as ready for review February 28, 2024 16:44
@lukavdplas lukavdplas added backend changes to the django backend corpus changes to corpus definitions or new corpora affects-elasticsearch-index changes that require re-indexing elasticsearch data labels Feb 28, 2024
@JeltevanBoheemen
Copy link
Contributor

Should I hold off on merging until reindexed? Or safe to merge?

@lukavdplas
Copy link
Contributor Author

lukavdplas commented Feb 29, 2024 •
edited
Loading

Let's hold off - I don't want the notes field to show up in the interface if it doesn't have values yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Meesch Meesch

Labels
affects-elasticsearch-index changes that require re-indexing elasticsearch data backend changes to the django backend corpus changes to corpus definitions or new corpora on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DBNL corpus: footnotes
3 participants
@lukavdplas @JeltevanBoheemen @Meesch