Meshfill animation #1249
Meshfill animation #1249
Conversation
|
@chaosphere2112 you to |
|
Tests are failing: https://open.cdash.org/viewTest.php?onlyfailed&buildid=3794735 Also, I'm having trouble figuring out the new variable name: doCellPointForScalar. What does this mean? It's the 'CellPoint' bit that's throwing me off. |
| if isinstance(gm,vcs.meshfill.Gfm): | ||
| doCellPointForScalar = True | ||
| else: | ||
| doCellPointForScalr = False |
|
Works for me, passes tests: https://open.cdash.org/viewTest.php?onlypassed&buildid=3795126 |
|
Would be nice to rename the variable to something better. Cell point is confusing.. |
|
@aashish24 the var actually says what it does, if set to True then when running Update for animation we need to do SetScalarRangeCellPoint so doCellPoint seemed like a good name. But feel free to edit and give a better name. Keep in mind with @dlonie updated workflow I suspect most of this will disappear... |
|
sure. @doutriaux1. Let's get it merged and we will clean it up if necessary with @dlonie's branch. |
@aashish24 @dlonie goes with: CDAT/uvcdat-testdata#44