Support django 4.2 #352
Merged
Support django 4.2 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assertQuerysetEqual is being deprecated in Django 5.1
Django's TestCase class deprecated the assertQuerysetEqual method in favor of assertQuerySetEqual. To handle testing on multiple versions of Django, when running tests if the Django version is < 4.2, redefine TestCase and add an assertQuerySetEqual method that calls the assertQuerysetEqual method. This is similar to handling the change in DeleteView in Django 4.0.
Django 4.1 is introducing a new template for rendering divs in forms. When testing using Django 4.1 or higher, set the temporary FORM_RENDERER setting. This setting will be removed in Django 6.0. https://docs.djangoproject.com/en/4.2/releases/4.1/#forms-4-1
The name included dj{} instead of django{}.
See commit 57a1cd3
The idea is that tox should skip django42 when running on mariadb 10.3 job.
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 117 117
Lines 20536 20547 +11
=======================================
+ Hits 20497 20508 +11
Misses 39 39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This class is a factory to create a TestWorkspaceData, but the pytest runner is finidng it. Modify the pytest.ini file to tell it to ignore this class.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.