Fixed exact restart (temporarily) - classic and image drivers #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 16, 2016 12:23
for both classic and image driver (This is a temporary solution to ensure exact restart)
|
The classic driver changes look good to me. I didn't look closely at the image driver changes. As an aside, I'm porting the classic driver changes to my fork of 4.2 and they appear to be functioning correctly there - this is a big help to me - thanks @yixinmao! |
|
@yixinmao - this looks good and can be merged, but first, can you add a bug fix note in the release notes: http://vic.readthedocs.io/en/develop/Development/ReleaseNotes/#bug-fixes. |
|
@jhamman I've edited the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assured exact restarts for classic and image driver under simple options (more thorough tests to be done). Specifically:
energy->LongUnderOutandenergy->snow_fluxare now saved to state file. This is a temporary solution to solving the main points in issue Exact restart - classic driver #479 and assuring exact restart.