Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open-mp threading #521

Closed
wants to merge 1 commit into from
Closed

Open-mp threading #521

wants to merge 1 commit into from

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jun 10, 2016

The current VIC MPI approach does not utilize threading for shared-memory on-node calculations. This might be expected to cause performance slow downs coming from a large number of MPI calls. This PR is introduces openmp threading to the vic_image_run loop over local_domain.ncells_active as proof of concept.

@bartnijssen
Copy link
Member

@jhamman: I don't want to try this for the time being. This should be shelved till after we have a working VIC 5 release. I am closing the PR for now, because I think this is a bit of a distraction, especially since at this time we don not even know whether it will provide a speed up or not.

@jhamman
Copy link
Member Author

jhamman commented Jun 10, 2016

That's fine @bartnijssen, I ran across this while working on something else and wanted to jot it down before I moved on and forgot how easy it could be. I labeled it someday so as to indicate its low priority. I'll open a separate issue (#522) but will not work on this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants